From 815441e47e74983a7a511436eb2cd39344911d55 Mon Sep 17 00:00:00 2001 From: Antoni Ivanov Date: Wed, 5 Oct 2022 12:33:58 +0300 Subject: [PATCH 1/4] vdk: update contributing.md Clarify the current status around PR using forks. --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2ac69fd715..a28b136de6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,8 +34,9 @@ We welcome many different types of contributions and not all of them need a Pull This is a rough outline of what a contributor's workflow looks like: -* Make a fork of the repository within your GitHub account -* Create a topic branch in your fork from where you want to base your work - name your branch according to our naming convention - person// +* Make a fork of the repository within your GitHub account + * Currently we accept contribution from forks only for examples and documentation changes until PR 854 is fixed. +* Create a topic branch from where you want to base your work - name your branch according to our naming convention - person// * Make commits of logical units * Make sure your commit messages are with the proper format, quality and descriptiveness (see below) * Push your changes to the topic branch in your fork From 046817340eb41f3bc8ad85f14d7c7da19695bafc Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 5 Oct 2022 09:37:16 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a28b136de6..b23753ea5c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,7 +34,7 @@ We welcome many different types of contributions and not all of them need a Pull This is a rough outline of what a contributor's workflow looks like: -* Make a fork of the repository within your GitHub account +* Make a fork of the repository within your GitHub account * Currently we accept contribution from forks only for examples and documentation changes until PR 854 is fixed. * Create a topic branch from where you want to base your work - name your branch according to our naming convention - person// * Make commits of logical units From 8f14a96f95a709093739b930925d37982f2fa10e Mon Sep 17 00:00:00 2001 From: Antoni Ivanov Date: Wed, 5 Oct 2022 12:41:15 +0300 Subject: [PATCH 3/4] update docs --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b23753ea5c..afa7100001 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -35,7 +35,7 @@ We welcome many different types of contributions and not all of them need a Pull This is a rough outline of what a contributor's workflow looks like: * Make a fork of the repository within your GitHub account - * Currently we accept contribution from forks only for examples and documentation changes until PR 854 is fixed. + * Currently we accept contribution from forks only for examples and documentation changes until PR 854 is fixed. Until then please request write priveleges and create a branch in the main repo. * Create a topic branch from where you want to base your work - name your branch according to our naming convention - person// * Make commits of logical units * Make sure your commit messages are with the proper format, quality and descriptiveness (see below) From 2d1892c6ca5078ef52a639f95d33ffcc028ac57b Mon Sep 17 00:00:00 2001 From: Antoni Ivanov Date: Wed, 5 Oct 2022 22:28:14 +0300 Subject: [PATCH 4/4] address comments --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index afa7100001..a04d4f32a9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,8 +34,8 @@ We welcome many different types of contributions and not all of them need a Pull This is a rough outline of what a contributor's workflow looks like: -* Make a fork of the repository within your GitHub account - * Currently we accept contribution from forks only for examples and documentation changes until PR 854 is fixed. Until then please request write priveleges and create a branch in the main repo. +* Use forks to only contribute changes on examples and documentation. + * Currently we accept contribution from forks only for examples and documentation changes until PR 854 is fixed. Until then please request write priveleges and create a branch in the main repo as described below. * Create a topic branch from where you want to base your work - name your branch according to our naming convention - person// * Make commits of logical units * Make sure your commit messages are with the proper format, quality and descriptiveness (see below)