Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Custom Log Renderers For Native Logging #2724

Closed
DeltaMichael opened this issue Sep 29, 2023 · 1 comment · Fixed by #2801
Closed

Create Custom Log Renderers For Native Logging #2724

DeltaMichael opened this issue Sep 29, 2023 · 1 comment · Fixed by #2801
Assignees
Labels
enhancement New feature or request initiative: VDK Run Logs story Task for an Epic

Comments

@DeltaMichael
Copy link
Contributor

Prerequisites

#2722

Overview

We should have log renderers that display our logs and the event dict params we add to them. We should at least have a JSON renderer and a console renderer.

The json renderer should just add custom values in the event dict to the json output as key-value pairs
The console renderer should parse the dict and add the custom values as tags, e.g.

2023-09-26 18:19:58 [info     ] 30_ingest_to_table.py Doing something awesome over here, boss

as opposed to what structlog does out of the box

2023-09-26 18:19:58 [info     ] Doing something awesome over here, boss step=30_ingest_to_table.py

Acceptance Criteria

  1. Create a console renderer
  2. Create a json renderer
@DeltaMichael
Copy link
Contributor Author

Addressed by #2801

@DeltaMichael DeltaMichael self-assigned this Oct 17, 2023
@DeltaMichael DeltaMichael linked a pull request Oct 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request initiative: VDK Run Logs story Task for an Epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant