Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python api client release process is broken #1979

Closed
murphp15 opened this issue Apr 27, 2023 · 0 comments · Fixed by #1983
Closed

Python api client release process is broken #1979

murphp15 opened this issue Apr 27, 2023 · 0 comments · Fixed by #1983
Labels
bug Something isn't working

Comments

@murphp15
Copy link
Collaborator

Describe the bug
At the moment the python client is broken. the function declerations in the latest client are not consistent with what we were using for the last few versions

Steps To Reproduce
Steps to reproduce the behavior:

  1. import 1.0.8 client into the vdk-cli project and its won't compile

Expected behavior
It should compile if you import it.
@murphp15 murphp15 added the bug Something isn't working label Apr 27, 2023
@murphp15 murphp15 mentioned this issue Apr 27, 2023
Merged
murphp15 added a commit that referenced this issue Apr 27, 2023
@murphp15
control-service: new python client. (#1983)
f1d3e7e 
# Why 
The newest python api client is broken and the last working one is very
old.

# What
In this PR I use the python-nextgen generator instead of the python
generator. The behaviour is much more correct and predictable.

There are two bugs in the generated code. 
For both these I have created tickets in the openapi generator github
project.

I have added string replace workarounds in the gradle step to fix these
bugs before we publish the pip package.


next steps(will be tackled in the next few weeks not days):
#1982

closes: #1979


# How has this been tested? 
Locally. 
There is actually a draft branch where I import this new version into
the cli project and run tests against it to confirm everything is green:
#1969

This will always fail in github because 1.0.9 is not released yet till
this PR is merged. Then I will open a new PR where I import into cli
tool.

Signed-off-by: murphp15 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

control-service: new python client. vmware/versatile-data-kit
1 participant
@murphp15