vdk-jupyter: removed py-to-ts-interfaces because of build problems #1690
Labels
Comments
duyguHsnHsn
added
bug
duyguHsnHsn
added a commit
that referenced
this issue
Mar 1, 2023
) What: Removed the py-to-ts-interfacesfrom from build. Created an issue about adding it again to the build - #1690 Why: It causes problems with the build and requires some hacky code to be build. Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected])
yonitoo
pushed a commit
that referenced
this issue
Mar 1, 2023
) What: Removed the py-to-ts-interfacesfrom from build. Created an issue about adding it again to the build - #1690 Why: It causes problems with the build and requires some hacky code to be build. Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected])
duyguHsnHsn
added a commit
that referenced
this issue
Mar 22, 2023
What: Added py-to-ts-interfaces to build. What the changes do: - Instruct npm to download the py-to-ts-interfaces package from the main branch of the repository located at https://github.com/Syndallic/py-to-ts-interfaces - build script by updating the "build:interfaces" script in the package.json (the npx command is used to run the installed py-to-ts-interfaces package) Why: linked to the issue #1690 Tests: tested manually the build by adding new options to VdkOptions in the python project Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected]) --------- Co-authored-by: Dilyan Marinov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When we add py-to-ts-interfaces to the vdk-jupyterlab-extension build, we get errors.
What should be done
The package should be added again in the build if possible.
If there is no way to it to be added, a new solution/ package should be found that can provide the same functionality as py-to-ts-interfaces.
Screenshots
The errors we get:
Additional context
Currently, the package will be removed from the build since it not a vital part of it (it is used mainly for development convenience).
The text was updated successfully, but these errors were encountered: