Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to create custom job builders #1357

Open
murphp15 opened this issue Nov 28, 2022 · 1 comment
Open

Document how to create custom job builders #1357

murphp15 opened this issue Nov 28, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@murphp15
Copy link
Collaborator

What is the feature request? What problem does it solve?
At the moment customers can create custom job builders but we don't have doc's on the details of creating these.

Suggested solution
Make sure that it describes how default secrets are loaded from the k8s secrets container called builder-secrets
@murphp15 murphp15 added the enhancement New feature or request label Nov 28, 2022
@murphp15 murphp15 mentioned this issue Nov 28, 2022
Merged
murphp15 added a commit that referenced this issue Nov 29, 2022
@murphp15
control-service: builder images load secrets from k8s (#1358)
152f772 
Why
I wrote this PR with the intent of being able to pass extra docker creds to to the image builder so that we would be able to pull a private base image from a docker repo.
The builder now contains login details for 2 registries. The registry it pushes to and the registry it pulls base image from.

However this PR also introduces the concept of builder secrets being sourced from k8s which leads to much cleaner separation between the control plane and the builder image. I think this will lead to much better support for custom build images in the future.

I'm not sure where to add the documentation about the builder-secrets. So I created a ticket to follow up on this later.
#1357

How was this been tested
tested extensively locally.
I added a test to check that the base image can be pulled from a private repo but in fact it is pulling from the same repo as it is pushing to and so it is could let bugs through related to the auth not working for the base image repo.

Signed-off-by: murphp15 <[email protected]>

* Google Java Format

Signed-off-by: murphp15 <[email protected]>
Co-authored-by: github-actions <>
@sabadzhiev sabadzhiev added the documentation Improvements or additions to documentation label Jun 22, 2023
@sabadzhiev
Copy link

Triaged. We will keep it, as being a Documentation enhancement that we would like to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murphp15 @sabadzhiev