Skip to content

Commit

Permalink
Google Java Format
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions committed Oct 9, 2023
1 parent c134a3e commit d681d2a
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ public class DataJobsSynchronizer {
* This can include creating new CronJobs, updating existing CronJobs, etc.
*/
@Scheduled(
fixedDelayString = "${datajobs.deployment.configuration.synchronization.task.interval:1000}",
initialDelayString = "${datajobs.deployment.configuration.synchronization.task.initial.delay:10000}")
fixedDelayString = "${datajobs.deployment.configuration.synchronization.task.interval:1000}",
initialDelayString =
"${datajobs.deployment.configuration.synchronization.task.initial.delay:10000}")
@SchedulerLock(name = "synchronizeDataJobsTask")
public void synchronizeDataJobs() {
if (!synchronizationEnabled) {
Expand All @@ -66,9 +67,11 @@ public void synchronizeDataJobs() {
}

if (!dataJobDeploymentPropertiesConfig
.getWriteTos()
.contains(DataJobDeploymentPropertiesConfig.WriteTo.DB)) {
log.debug("Skipping data job deployments' synchronization due to the disabled writes to the database.");
.getWriteTos()
.contains(DataJobDeploymentPropertiesConfig.WriteTo.DB)) {
log.debug(
"Skipping data job deployments' synchronization due to the disabled writes to the"
+ " database.");
return;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,56 +65,59 @@ public class DataJobsSynchronizerTest {

@Test
void synchronizeDataJobs_synchronizationEnabledFalseAndWriteToDbTrue_shouldSkipSynchronization()
throws ApiException {
throws ApiException {
initSynchronizationProcessConfig(false, true);

dataJobsSynchronizer.synchronizeDataJobs();

Mockito.verify(deploymentService, Mockito.times(0))
.findAllActualDeploymentNamesFromKubernetes();
.findAllActualDeploymentNamesFromKubernetes();
}

@Test
void synchronizeDataJobs_synchronizationEnabledFalseAndWriteToDbFalse_shouldSkipSynchronization()
throws ApiException {
throws ApiException {
initSynchronizationProcessConfig(false, false);

dataJobsSynchronizer.synchronizeDataJobs();

Mockito.verify(deploymentService, Mockito.times(0))
.findAllActualDeploymentNamesFromKubernetes();
.findAllActualDeploymentNamesFromKubernetes();
}

@Test
void
synchronizeDataJobs_synchronizationEnabledTrueAndWriteToDbTrue_shouldFinishSynchronization()
throws ApiException {
void synchronizeDataJobs_synchronizationEnabledTrueAndWriteToDbTrue_shouldFinishSynchronization()
throws ApiException {
initSynchronizationProcessConfig(true, true);

dataJobsSynchronizer.synchronizeDataJobs();

Mockito.verify(deploymentService, Mockito.times(1))
.findAllActualDeploymentNamesFromKubernetes();
.findAllActualDeploymentNamesFromKubernetes();
}

@Test
void
synchronizeDataJobs_synchronizationEnabledTrueAndWriteToDbFalse_shouldSkipSynchronization()
throws ApiException {
void synchronizeDataJobs_synchronizationEnabledTrueAndWriteToDbFalse_shouldSkipSynchronization()
throws ApiException {
initSynchronizationProcessConfig(true, false);

dataJobsSynchronizer.synchronizeDataJobs();

Mockito.verify(deploymentService, Mockito.times(0))
.findAllActualDeploymentNamesFromKubernetes();
.findAllActualDeploymentNamesFromKubernetes();
}

void enableSynchronizationProcess() {
initSynchronizationProcessConfig(true, true);
}

void initSynchronizationProcessConfig(boolean synchronizationEnabled, boolean writeToDB) {
ReflectionTestUtils.setField(dataJobsSynchronizer, "synchronizationEnabled", synchronizationEnabled);
Mockito.when(dataJobDeploymentPropertiesConfig.getWriteTos()).thenReturn(writeToDB ? Set.of(DataJobDeploymentPropertiesConfig.WriteTo.DB) : Collections.emptySet());
ReflectionTestUtils.setField(
dataJobsSynchronizer, "synchronizationEnabled", synchronizationEnabled);
Mockito.when(dataJobDeploymentPropertiesConfig.getWriteTos())
.thenReturn(
writeToDB
? Set.of(DataJobDeploymentPropertiesConfig.WriteTo.DB)
: Collections.emptySet());
}
}

0 comments on commit d681d2a

Please sign in to comment.