frontend: Align code formatting in frontend projects (#1863)

Aligned formatting in shared and data-pipelines frontend using same configuration for prettier and .editorconfig Executed auto format on project data-pipelines. No regression are expected, because only formatting is committed. Tested local builds, linking built lib to UI and manual validatino on every screen, and seems there is no problems. ESLint executed successfully and there no issues. Addressing issue #1801 --------- Signed-off-by: gorankokin <[email protected]> --------- Signed-off-by: gorankokin <[email protected]> Co-authored-by: Goran Kokinovski <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
vmware · Apr 11, 2023 · 1542dfc · 1542dfc
1 parent 78c3217
commit 1542dfc
Show file tree

Hide file tree

Showing 141 changed files with 1,978 additions and 3,954 deletions.
diff --git a/projects/frontend/data-pipelines/gui/.editorconfig b/projects/frontend/data-pipelines/gui/.editorconfig
@@ -9,7 +9,7 @@ insert_final_newline = true
 trim_trailing_whitespace = true
 
 [*.{ts, html}]
-max_line_length = 80
+max_line_length = 140
 
 [*.{ts, js}]
 quote_type = single

diff --git a/projects/frontend/data-pipelines/gui/.eslintrc.json b/projects/frontend/data-pipelines/gui/.eslintrc.json
@@ -12,7 +12,16 @@
       ]
     },
     "import/resolver": {
-      "typescript": {}
+      "typescript": {
+        "project": [
+          "tsconfig.json"
+        ]
+      },
+      "node": {
+        "project": [
+          "tsconfig.json"
+        ]
+      }
     }
   },
   "overrides": [

diff --git a/projects/frontend/data-pipelines/gui/.prettierrc.json b/projects/frontend/data-pipelines/gui/.prettierrc.json
@@ -3,7 +3,7 @@
   "semi": true,
   "singleQuote": true,
   "quoteProps": "as-needed",
-  "trailingComma": "all",
+  "trailingComma": "none",
   "bracketSpacing": true,
   "jsxBracketSameLine": true,
   "arrowParens": "always",

diff --git a/...s/frontend/data-pipelines/gui/e2e/integration/app/getting-started/getting-started.spec.js b/...s/frontend/data-pipelines/gui/e2e/integration/app/getting-started/getting-started.spec.js
@@ -27,7 +27,7 @@ describe('Getting Started Page', { tags: ['@dataPipelines'] }, () => {
 
                 return cy.wrap({
                     context: 'getting-started.spec::before()',
-                    action: 'continue',
+                    action: 'continue'
                 });
             });
     });
@@ -47,8 +47,8 @@ describe('Getting Started Page', { tags: ['@dataPipelines'] }, () => {
             .getMainTitle()
             .should(($el) =>
                 expect($el.text().trim()).to.equal(
-                    'Get Started with Data Pipelines',
-                ),
+                    'Get Started with Data Pipelines'
+                )
             );
     });
 
@@ -113,7 +113,7 @@ describe('Getting Started Page', { tags: ['@dataPipelines'] }, () => {
 
             // navigate to most recent failing job executions
             dataJobsHealthPanel.navigateToMostRecentFailingJobExecutions(
-                testJob.job_name,
+                testJob.job_name
             );
 
             const dataJobManageExecutionsPage =

diff --git a/projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-job-details.spec.js b/projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-job-details.spec.js
@@ -18,7 +18,7 @@ describe(
         before(() => {
             return DataJobExploreDetailsPage.recordHarIfSupported()
                 .then(() =>
-                    cy.clearLocalStorageSnapshot('data-job-explore-details'),
+                    cy.clearLocalStorageSnapshot('data-job-explore-details')
                 )
                 .then(() => DataJobExploreDetailsPage.login())
                 .then(() => cy.saveLocalStorage('data-job-explore-details'))
@@ -30,7 +30,7 @@ describe(
 
                     return cy.wrap({
                         context: 'explore::data-job-details.spec::before()',
-                        action: 'continue',
+                        action: 'continue'
                     });
                 });
         });
@@ -54,7 +54,7 @@ describe(
 
             dataJobsExplorePage.openJobDetails(
                 testJobs[0].team,
-                testJobs[0].job_name,
+                testJobs[0].job_name
             );
 
             dataJobExploreDetailsPage = DataJobExploreDetailsPage.getPage();
@@ -86,7 +86,7 @@ describe(
                 .should('be.visible')
                 .should(
                     'contains.text',
-                    'At 12:00 AM, on day 01 of the month, and on Friday',
+                    'At 12:00 AM, on day 01 of the month, and on Friday'
                 );
 
             // DISABLED Because there is no Source at the moment.
@@ -101,7 +101,7 @@ describe(
                 .should('be.visible')
                 .should(
                     'contains.text',
-                    testJobs[0].config.contacts.notified_on_job_deploy,
+                    testJobs[0].config.contacts.notified_on_job_deploy
                 );
 
             dataJobExploreDetailsPage
@@ -110,7 +110,7 @@ describe(
                 .should(
                     'contains.text',
                     testJobs[0].config.contacts
-                        .notified_on_job_failure_platform_error,
+                        .notified_on_job_failure_platform_error
                 );
 
             dataJobExploreDetailsPage
@@ -119,15 +119,15 @@ describe(
                 .should(
                     'contains.text',
                     testJobs[0].config.contacts
-                        .notified_on_job_failure_user_error,
+                        .notified_on_job_failure_user_error
                 );
 
             dataJobExploreDetailsPage
                 .getOnSuccessField()
                 .should('be.visible')
                 .should(
                     'contains.text',
-                    testJobs[0].config.contacts.notified_on_job_success,
+                    testJobs[0].config.contacts.notified_on_job_success
                 );
         });
 
@@ -138,7 +138,7 @@ describe(
 
             dataJobsExplorePage.openJobDetails(
                 testJobs[0].team,
-                testJobs[0].job_name,
+                testJobs[0].job_name
             );
 
             const dataJobExploreDetailsPage =
@@ -162,7 +162,7 @@ describe(
 
             dataJobsExplorePage.openJobDetails(
                 testJobs[0].team,
-                testJobs[0].job_name,
+                testJobs[0].job_name
             );
 
             const dataJobExploreDetailsPage =
@@ -179,5 +179,5 @@ describe(
                 .getActionDropdownBtn()
                 .should('not.exist');
         });
-    },
+    }
 );
diff --git a/projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-job-executions.spec.js b/projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-job-executions.spec.js
@@ -18,7 +18,7 @@ describe(
         before(() => {
             return DataJobBasePO.recordHarIfSupported()
                 .then(() =>
-                    cy.clearLocalStorageSnapshot('data-job-explore-executions'),
+                    cy.clearLocalStorageSnapshot('data-job-explore-executions')
                 )
                 .then(() => DataJobBasePO.login())
                 .then(() => cy.saveLocalStorage('data-job-explore-executions'))
@@ -30,7 +30,7 @@ describe(
 
                     return cy.wrap({
                         context: 'explore::data-job-executions.spec::before()',
-                        action: 'continue',
+                        action: 'continue'
                     });
                 });
         });
@@ -54,7 +54,7 @@ describe(
 
             dataJobsExplorePage.openJobDetails(
                 testJobs[0].team,
-                testJobs[0].job_name,
+                testJobs[0].job_name
             );
 
             const dataJobBasePage = DataJobBasePO.getPage();
@@ -71,7 +71,7 @@ describe(
 
         it('Data Job Explore Executions Page - should verify on URL navigate to Executions will redirect to Details', () => {
             const dataJobBasePage = DataJobBasePO.navigateToUrl(
-                `/explore/data-jobs/${testJobs[0].team}/${testJobs[0].job_name}/executions`,
+                `/explore/data-jobs/${testJobs[0].team}/${testJobs[0].job_name}/executions`
             );
 
             dataJobBasePage
@@ -84,11 +84,11 @@ describe(
                 .should(
                     'match',
                     new RegExp(
-                        `\\/explore\\/data-jobs\\/${testJobs[0].team}\\/${testJobs[0].job_name}\\/details$`,
-                    ),
+                        `\\/explore\\/data-jobs\\/${testJobs[0].team}\\/${testJobs[0].job_name}\\/details$`
+                    )
                 );
 
             dataJobBasePage.getDetailsTab().should('have.class', 'active');
         });
-    },
+    }
 );
diff --git a/projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-jobs.spec.js b/projects/frontend/data-pipelines/gui/e2e/integration/lib/explore/data-jobs.spec.js
@@ -28,7 +28,7 @@ describe(
 
                     return cy.wrap({
                         context: 'explore::data-jobs.spec::before()',
-                        action: 'continue',
+                        action: 'continue'
                     });
                 });
         });
@@ -52,7 +52,7 @@ describe(
                 .getMainTitle()
                 .should('be.visible')
                 .should(($el) =>
-                    expect($el.text().trim()).to.equal('Explore Data Jobs'),
+                    expect($el.text().trim()).to.equal('Explore Data Jobs')
                 );
         });
 
@@ -114,13 +114,13 @@ describe(
                     dataJobsExplorePage.refreshDataGrid();
 
                     dataJobsExplorePage.filterByJobName(
-                        normalizedTestJob.job_name,
+                        normalizedTestJob.job_name
                     );
 
                     dataJobsExplorePage
                         .getDataGridCell(normalizedTestJob.job_name)
                         .should('have.text', normalizedTestJob.job_name);
-                },
+                }
             );
         });
 
@@ -251,7 +251,7 @@ describe(
                 .invoke('join', ',')
                 .should(
                     'eq',
-                    'Description,Deployment Status,Last Execution Duration,Success rate,Next run (UTC),Last Deployed (UTC),Last Deployed By,Source,Logs',
+                    'Description,Deployment Status,Last Execution Duration,Success rate,Next run (UTC),Last Deployed (UTC),Last Deployed By,Source,Logs'
                 );
 
             // verify column is not checked in toggling menu
@@ -267,7 +267,7 @@ describe(
 
             // toggle column to render
             dataJobsExplorePage.checkColumnShowHideOption(
-                'Last Execution Duration',
+                'Last Execution Duration'
             );
 
             // verify column is checked in toggling menu
@@ -283,7 +283,7 @@ describe(
 
             // toggle column to hide
             dataJobsExplorePage.uncheckColumnShowHideOption(
-                'Last Execution Duration',
+                'Last Execution Duration'
             );
 
             // verify column is not checked in toggling menu
@@ -308,7 +308,7 @@ describe(
 
             dataJobsExplorePage.openJobDetails(
                 testJobs[0].team,
-                testJobs[0].job_name,
+                testJobs[0].job_name
             );
 
             const dataJobExploreDetailsPage =
@@ -324,5 +324,5 @@ describe(
                 .should('be.visible')
                 .should('contain.text', testJobs[0].description);
         });
-    },
+    }
 );