Skip to content

Commit

Permalink
vdk-jupyter: pin lumino/widgets package to version 1 (#2099)
Browse files Browse the repository at this point in the history
What:
Pinned lumino/widgets to 1.33.0

Why:
Jupyterlab 4 is released some days ago, and it bumps the latest
version of rendermime-interface to 3.8.0, which is not compatible with
lumino 1.x
Because of that. we pinned render mime-interface to 3.6.3 which is best
compatible with lumino 1.x and causes problems with lumina 2.x, I pinned
the lumina to the lates stable 1.x version
This caused Build issues: 
![Screenshot 2023-05-18 at 15 29

27](https://github.com/vmware/versatile-data-kit/assets/87015481/9407ae37-519b-4224-b16c-776d62bd2374)


Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected])
  • Loading branch information
duyguHsnHsn authored May 22, 2023
1 parent a017243 commit 01c8113
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"build:prod": "jlpm clean && jlpm build:lib && jlpm build:labextension",
"build:labextension": "jupyter labextension build .",
"build:labextension:dev": "jupyter labextension build --development True .",
"build:lib": "tsc",
"build:lib": "npm update && tsc",
"build:interfaces": "pip install py-to-ts-interfaces && py-to-ts-interfaces vdk_jupyterlab_extension/vdk_options/ src/vdkOptions",
"clean": "jlpm clean:lib",
"clean:lib": "rimraf lib tsconfig.tsbuildinfo",
Expand Down Expand Up @@ -68,7 +68,7 @@
"@jupyterlab/builder": "^3.1.0",
"@jupyterlab/rendermime-interfaces": "3.6.3",
"@jupyterlab/testutils": "^3.0.0",
"@lumino/widgets": "^2.1.1",
"@lumino/widgets": "1.33.0",
"@testing-library/react": "12.1.5",
"@types/enzyme": "^3.10.12",
"@types/jest": "^26.0.0",
Expand Down

0 comments on commit 01c8113

Please sign in to comment.