Incorrect ResourceType for NSX Edge

[insidepacket]

Code of Conduct

• I have read and agree to the Code of Conduct.
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

v.1.9.4

Terraform Provider

v0.10.0

VMware Cloud Foundation

v5

Description

When using resource type NSX_Edge to rotate NSX Edge credentials. It can't find any NSX edge credentials although the API calls can retrieve NSX Edge system credentials. I have identified the issue: The provider requests resourceType: NSX_EDGE but API response suggest that the right resourceType: NSXT_EDGE.

Affected Resources or Data Sources

r/credentials

Terraform Configuration

https://gist.github.com/insidepacket/b549c31c581b4f9f70cda66750039dc1

Debug Output

https://gist.github.com/insidepacket/b549c31c581b4f9f70cda66750039dc1

Panic Output

No response

Expected Behavior

Can get the NSX Edge system credentials and rotate it.

Actual Behavior

Unable to find any NSX Edge system credentials.

Steps to Reproduce

Step 1: stand up a VCF instance or have an existing instance.
Step 2: create the TF template
Step 3: terraform apply or terraform plan.

Environment Details

No response

Screenshots

No response

References

No response

[tenthirtyam]

Issue seems to be from the following const for ResourceTypeNsxEdge in L15.

terraform-provider-vcf/internal/credentials/constants.go

Lines 9 to 24 in b2f7851

	const (
	ResourceTypeEsxi = "ESXI"
	ResourceTypeVcenter = "VCENTER"
	ResourceTypePsc = "PSC"
	ResourceTypeNsxManager = "NSX_MANAGER"
	ResourceTypeNsxController = "NSX_CONTROLLER"
	ResourceTypeNsxEdge = "NSX_EDGE"
	ResourceTypeNsxtManager = "NSXT_MANAGER"
	ResourceTypeVrli = "VRLI"
	ResourceTypeVra = "VRA"
	ResourceTypeWsa = "WSA"
	ResourceTypeVrslcm = "VRSLCM"
	ResourceTypeVxrailManager = "VXRAIL_MANAGER"
	ResourceTypeNsxAlb = "NSX_ALB"
	ResourceTypeBackup = "BACKUP"
	)

[insidepacket]

@tenthirtyam, you were faster than me to create the PR.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.