Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for detailed workflow status #204

Closed
4 tasks done
pradeep17j opened this issue Jul 27, 2024 · 6 comments · Fixed by #268
Closed
4 tasks done

Add support for detailed workflow status #204

pradeep17j opened this issue Jul 27, 2024 · 6 comments · Fixed by #268
Assignees
Labels
enhancement Enhancement provider Provider
Milestone

Comments

@pradeep17j
Copy link

pradeep17j commented Jul 27, 2024

Code of Conduct

  • I have read and agree to the project's Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

When bringup is happening, the output from terraform apply command says:

vcf_instance.sddc_instance: Still creating... [1h20m40s elapsed]
vcf_instance.sddc_instance: Still creating... [1h20m50s elapsed]
vcf_instance.sddc_instance: Still creating... [1h21m00s elapsed]

This does not give any insight into what is happening in the background. Also when there is a failure, we will have to login to CB or SDDC to find the point of failure.

A task API like below returns back the detailed status of sub-task in progress.
https://10.0.0.215/v1/sddcs/290051a3-1725-4edc-9df9-6e94655cec0d

The CB UI utilizes this API to display the granular detail of sub-task in progress.

The provider also should utilize this API and display the details instead of
"Still creating ....." message.

Use Case(s)

Will help user get a granular view of sub-task in progress.

Potential Configuration

A detailed display for long running tasks.

References

No response

@pradeep17j pradeep17j added enhancement Enhancement needs-review Needs Review labels Jul 27, 2024
@github-actions github-actions bot added the pending-review Pending Review label Jul 27, 2024
@pradeep17j
Copy link
Author

pradeep17j commented Jul 27, 2024

The sub-task messages should look like below

Generate Security Thumbprints Input Data post-validation completed!

Validate Security Thumbprints post-validation completed!

Generate input for Trust Certificates post-validation completed!

Trust Certificates post-validation completed!

Generate input for Import SSH Keys post-validation completed!

@tenthirtyam tenthirtyam removed needs-review Needs Review pending-review Pending Review labels Jul 27, 2024
@tenthirtyam tenthirtyam changed the title Detailed status not available when workflows are in progress Add supprt for detailed workfloa status Jul 30, 2024
@tenthirtyam tenthirtyam added this to the Backlog milestone Jul 30, 2024
@tenthirtyam tenthirtyam changed the title Add supprt for detailed workfloa status Add support for detailed workflow status Jul 30, 2024
@tenthirtyam tenthirtyam added the provider Provider label Jul 30, 2024
@spacegospod
Copy link
Contributor

Hey @pradeep17j I've been experimenting with this for a while now and my idea is slightly different than what you've proposed.
Feel free to check out my PR and comment

@tenthirtyam
Copy link
Collaborator

Feel free to check out my PR and comment

This is certainly more aligned with common Terraform operations. 🔥 🚀

@tenthirtyam
Copy link
Collaborator

#227 has been merged.

Integration of the task tracker will need to be added on a per resource / data source as required. Once integrated, to enable the new logging one must set TF_LOG_PROVIDER_VCF to a valid log level.

Copy link

'Marking this issue as stale due to inactivity. This helps us focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context.
Thank you!'

Copy link

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
@tenthirtyam tenthirtyam modified the milestones: Backlog, v0.13.0 Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement provider Provider
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants