Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsim: add PlaceVm support #1589

Merged
merged 3 commits into from
Sep 5, 2019
Merged

vcsim: add PlaceVm support #1589

merged 3 commits into from
Sep 5, 2019

Conversation

dougm
Copy link
Member

@dougm dougm commented Sep 4, 2019

  • Add ClusterComputeResource.PlaceVm wrapper

  • Add govc vm.clone -cluster flag

  • Add govc vm.create -cluster flag

Fixes #1580

- Add ClusterComputeResource.PlaceVm wrapper

- Add govc vm.clone -cluster flag

- Add govc vm.create -cluster flag

Fixes vmware#1580
@dougm
Copy link
Member Author

dougm commented Sep 4, 2019

@akrits can you review?

Copy link

@akrits akrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

@dougm dougm merged commit c183577 into vmware:master Sep 5, 2019
@dougm dougm deleted the vcsim-placevm branch September 5, 2019 22:42
dougm added a commit to dougm/govmomi that referenced this pull request Nov 15, 2019
PR vmware#1589 added the '-cluster' flag to vm.clone and vm.create commands.
However, the GOVC_CLUSTER env var should not be used as a default.

Fixes vmware#1712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcsim: PlaceVM method is not implemented
3 participants