Set PVC storage request at restore time to volumesnapshot size.

[kaovilai]

We may want to set the requested storage for PVC being restored to the higher value between backedUpPVC.spec.request.storage.size and volumesnapshot.status.restoresize.

Describe the problem/challenge you have
[A description of the current limitation/problem/challenge that you are experiencing.]

• Created PVC-A with 100MiB request
  • ebs driver rounds up storage capacity to nearest GiB, in this case 1GiB
• Backup Pod and PVC using velero with gp2-csi
  • snapshot taken has the size of 1GiB
• Restore Pod and PVC
  • velero try to recreate PVC with 100MiB storage request with a 1GiB VolumeSnapshot as dataSource
    • ERROR

Result:

Generated from ebs.csi.aws.com_<nodeip>_<uuid?>
9 times in the last 3 minutes
failed to provision volume with StorageClass "gp2-csi": error getting handle for DataSource Type VolumeSnapshot by Name velero-pc-data-lmkpz: requested volume size 104857600 is less than the size 1073741824 for the source snapshot velero-pc-data-lmkpz

Issue filed in csi driver
kubernetes-sigs/aws-ebs-csi-driver#1209
This issue may exist with other drivers as well.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Some mitigation or documentation around this "known issue".

• tell users to request in 1GiB increments when using EBS
• restoredPVC.requestedCapacity = backedUpPVC.Capacity -> (therefore) restoredPVC.requestedCapacity = volumesnapshot.status.restoreSize

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Velero version (use velero version):
• Kubernetes version (use kubectl version):
• Kubernetes installer & version:
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• 👍 for "The project would be better with this feature added"
• 👎 for "This feature will not enhance the project in a meaningful way"