Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline markup is ignored inside parenthesis #256

Closed
nono opened this issue May 29, 2013 · 4 comments · Fixed by #270
Closed

Inline markup is ignored inside parenthesis #256

nono opened this issue May 29, 2013 · 4 comments · Fixed by #270
Assignees
Labels

Comments

@nono
Copy link
Contributor

nono commented May 29, 2013

Hi,

inline markup, like italics, is ignored inside parenthesis with no_intra_emphasis. For example:

markdown = Redcarpet::Markdown.new(Redcarpet::Render::HTML, no_intra_emphasis: true)
markdown.render "Foo (_bar_)"
# => "<p>Foo (_bar_)</p>\n"

In fact, it's only the opening parenthesis that blocks it. If we had a space after it, it works:

markdown.render "Foo ( _bar_)"
# => "<p>Foo ( <em>bar</em>)</p>\n"
@nono
Copy link
Contributor Author

nono commented May 29, 2013

There is the same issue after a non-breaking space:

markdown = Redcarpet::Markdown.new(Redcarpet::Render::HTML, no_intra_emphasis: true)
markdown.render "There is a non-breaking space here -> **foo**  bar"
# => "<p>There is a non-breaking space here -&gt; **foo**  bar</p>\n"

@ghost ghost assigned robin850 Jun 7, 2013
@robin850
Copy link
Collaborator

I plan to fix it as soon as possible. Thanks for reporting!

@robin850
Copy link
Collaborator

This has been fixed! Thanks for reporting. Have a nice day. 😃

@vmg : Could you please backport this into GitHub? It's quite a redundant bug. Thanks.

@nono
Copy link
Contributor Author

nono commented Jun 15, 2013

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants