Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Testing - Use torch.testing.assert_close instead of torch.allclose as a Recommended Practice #7307

Closed
jon-chuang opened this issue Aug 8, 2024 · 0 comments · Fixed by #7324
Closed

[Feature]: Testing - Use torch.testing.assert_close instead of torch.allclose as a Recommended Practice #7307

jon-chuang opened this issue Aug 8, 2024 · 0 comments · Fixed by #7324
Labels
feature request good first issue Good for newcomers

Comments

@jon-chuang
Copy link
Contributor

jon-chuang commented Aug 8, 2024 •
edited
Loading

🚀 The feature, motivation and pitch

See https://pytorch.org/docs/stable/testing.html

assert_close will print the values which violate the allclose condition. assert torch.allclose will not

This leads to better diagnosability of failed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Misc/Testing] Use torch.testing.assert_close jon-chuang/vllm
2 participants
@mgoin @jon-chuang