Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [SpecDecode] Speculative metrics very unlikely to get logged #6643

Closed
tdoublep opened this issue Jul 22, 2024 · 0 comments · Fixed by #6645
Closed

[Bug] [SpecDecode] Speculative metrics very unlikely to get logged #6643

tdoublep opened this issue Jul 22, 2024 · 0 comments · Fixed by #6645
Labels
bug Something isn't working

Comments

@tdoublep
Copy link
Member

Your current environment

n/a

🐛 Describe the bug

After merging #6578, the AsyncMetricsCollector now respects the time interval between collecting speculative decoding metrics. It now collects the metrics every 5 seconds, instead of continuously collecting them.

While this is the desired behaviour, I now see that in practice, we are never logging the speculative decoding stats. This is because, in order to get logged, the speculative decoding stats need to happen to be collected in exactly the same step that we decide to log the output (which is controlled by a different time interval). In practice, this does not seem to happen using the default settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant