Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Helm values example to use new hf_token value #65

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

0xThresh
Copy link
Contributor

@0xThresh 0xThresh commented Feb 4, 2025

#22 updated the schema to use hf_token instead of an environment variable config in Values.yaml, but the commented out example in the values file was not updated to reflect this. This PR corrects the example to use the new hf_token value.

Copy link
Collaborator

@ApostaC ApostaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@ApostaC ApostaC merged commit 6003fbb into vllm-project:main Feb 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants