Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use secrets to configure HF_TOKEN #22

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ApostaC
Copy link
Collaborator

@ApostaC ApostaC commented Jan 26, 2025

This PR fixes #14

Now the deployment uses the secret in the helm chart to hold the hugging face token, which can be safely referenced in the deployment.

@ApostaC ApostaC changed the title Use secrets to configure HF_TOKEN feat: Use secrets to configure HF_TOKEN Jan 26, 2025
@ApostaC ApostaC requested a review from KuntaiDu January 26, 2025 23:42
@ApostaC ApostaC merged commit 846e74e into vllm-project:main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tutorials all suggest storing your tokens as plaintext
2 participants