Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of 1k prompts. #127

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

ggaaooppeenngg
Copy link
Contributor

@ggaaooppeenngg ggaaooppeenngg commented Feb 14, 2025

httpx client has a default max_connections(100) which will block the requests if the concurrency is over 100.

This commit enhances the router's concurrency capabilities. Key changes:

  1. Set httpx.AsyncClient max connections to unlimited to unblock the requests.
  2. In process_request, overwrite host header for proxies routing by host.
  3. Call set_ulimit in main to prevent uvicorn from dropping requests due to high FD count.

@ggaaooppeenngg ggaaooppeenngg changed the title 1k prompts Fix the problem of 1k prompts. Feb 14, 2025
@gaocegege
Copy link
Collaborator

Thanks for your contribution! 🎉 👍

Please fix the pre commit linting issues.

This commit enhances the router's concurrency capabilities. Key changes:
1. Set `httpx.AsyncClient` max connections to unlimited to unblock the requests.
2. In `process_request`, overwrite host header for proxies routing by host.
3. Call `set_ulimit` in `main` to prevent uvicorn from dropping requests due to high FD count.

Signed-off-by: Peng Gao <[email protected]>
@ggaaooppeenngg
Copy link
Contributor Author

@gaocegege Done!

gaocegege
gaocegege previously approved these changes Feb 15, 2025
Copy link
Collaborator

@ApostaC ApostaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions! Otherwise LGTM!

Copy link
Collaborator

@ApostaC ApostaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ApostaC ApostaC merged commit 7156594 into vllm-project:main Feb 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants