We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just a heads up that all of your tutorials suggest setting your HF token in plaintext as an environment variable in the deployments like
env: - name: HF_TOKEN value: <YOUR_HF_TOKEN>
This might be fine to do on a local minikube cluster on your machine, but it's super unsafe to do on a remote cluster.
I'd suggest setting up a secret in the helm chart to hold the token, so that it can be safely referenced in the deployment instead like:
env - name: HF_TOKEN valueFrom: secretKeyRef: name: hf-token-secret key: token
The text was updated successfully, but these errors were encountered:
Thanks for pointing it out! This is on our current TODO list and will be updated soon.
Sorry, something went wrong.
Hey @joerunde , I just created PR #22 to fix this. Feel free to take a look and leave your comments there.
ApostaC
Successfully merging a pull request may close this issue.
Just a heads up that all of your tutorials suggest setting your HF token in plaintext as an environment variable in the deployments like
This might be fine to do on a local minikube cluster on your machine, but it's super unsafe to do on a remote cluster.
I'd suggest setting up a secret in the helm chart to hold the token, so that it can be safely referenced in the deployment instead like:
The text was updated successfully, but these errors were encountered: