From 286a3f4edddbed725f76340a9b1388732d425636 Mon Sep 17 00:00:00 2001 From: Hanchenli <61769611+Hanchenli@users.noreply.github.com> Date: Thu, 20 Feb 2025 12:18:10 -0600 Subject: [PATCH] Fixed some tutorial problems (#160) * Updated AWS, bumped release version Signed-off-by: hanchenli * minor fix to readme in aws Signed-off-by: hanchenli * minor fix to readme in aws Signed-off-by: hanchenli * fix format Signed-off-by: hanchenli * fix folder Signed-off-by: hanchenli * fix tutorial Signed-off-by: hanchenli * Fix GKE deployment tutorial Signed-off-by: hanchenli --------- Signed-off-by: hanchenli --- deployment_on_cloud/aws/clean_up.sh | 26 +------------------ deployment_on_cloud/{gke => gcp}/README.md | 0 deployment_on_cloud/{gke => gcp}/clean_up.sh | 0 .../{gke => gcp}/entry_point.sh | 0 .../production_stack_specification.yaml | 0 .../02-GCP-GKE-deployment.md | 4 +-- 6 files changed, 3 insertions(+), 27 deletions(-) rename deployment_on_cloud/{gke => gcp}/README.md (100%) rename deployment_on_cloud/{gke => gcp}/clean_up.sh (100%) rename deployment_on_cloud/{gke => gcp}/entry_point.sh (100%) rename deployment_on_cloud/{gke => gcp}/production_stack_specification.yaml (100%) diff --git a/deployment_on_cloud/aws/clean_up.sh b/deployment_on_cloud/aws/clean_up.sh index cb50a0d..6364706 100644 --- a/deployment_on_cloud/aws/clean_up.sh +++ b/deployment_on_cloud/aws/clean_up.sh @@ -110,32 +110,8 @@ aws eks delete-cluster --name "$CLUSTER_NAME" --region "$REGION" echo "Waiting for cluster $CLUSTER_NAME to be deleted..." aws eks wait cluster-deleted --name "$CLUSTER_NAME" --region "$REGION" +# TODO # Clean up VPC -# echo "Cleaning up VPC..." -# VPC_ID=$(aws ec2 describe-vpcs \ -# --filters "Name=tag:Name,Values=eksctl-${CLUSTER_NAME}-cluster/VPC" \ -# --query "Vpcs[0].VpcId" \ -# --output text \ -# --region "$REGION") -# if [ -n "$VPC_ID" ]; then -# echo "Deleting VPC: $VPC_ID" -# aws ec2 delete-vpc --vpc-id "$VPC_ID" --region "$REGION" -# else -# echo "VPC not found, skipping..." -# fi - # Delete CloudFormation Stackecho "Deleting CloudFormation stacks..." -# STACKS=( "eksctl-${CLUSTER_NAME}-cluster" "eksctl-${CLUSTER_NAME}-cluster-nodegroup-gpu-nodegroup" ) -# for STACK_NAME in "${STACKS[@]}"; do -# STACK_STATUS=$(aws cloudformation describe-stacks --stack-name "$STACK_NAME" --region "$REGION" --query "Stacks[0].StackStatus" --output text 2>/dev/null) -# if [ -n "$STACK_STATUS" ]; then -# echo "Deleting CloudFormation stack: $STACK_NAME" -# aws cloudformation delete-stack --stack-name "$STACK_NAME" --region "$REGION" -# echo "Waiting for CloudFormation stack $STACK_NAME to be deleted..." -# aws cloudformation wait stack-delete-complete --stack-name "$STACK_NAME" --region "$REGION" -# else -# echo "CloudFormation stack $STACK_NAME not found, skipping..." -# fi -# done echo "EKS cluster $CLUSTER_NAME cleanup completed successfully!" diff --git a/deployment_on_cloud/gke/README.md b/deployment_on_cloud/gcp/README.md similarity index 100% rename from deployment_on_cloud/gke/README.md rename to deployment_on_cloud/gcp/README.md diff --git a/deployment_on_cloud/gke/clean_up.sh b/deployment_on_cloud/gcp/clean_up.sh similarity index 100% rename from deployment_on_cloud/gke/clean_up.sh rename to deployment_on_cloud/gcp/clean_up.sh diff --git a/deployment_on_cloud/gke/entry_point.sh b/deployment_on_cloud/gcp/entry_point.sh similarity index 100% rename from deployment_on_cloud/gke/entry_point.sh rename to deployment_on_cloud/gcp/entry_point.sh diff --git a/deployment_on_cloud/gke/production_stack_specification.yaml b/deployment_on_cloud/gcp/production_stack_specification.yaml similarity index 100% rename from deployment_on_cloud/gke/production_stack_specification.yaml rename to deployment_on_cloud/gcp/production_stack_specification.yaml diff --git a/tutorials/cloud_deployments/02-GCP-GKE-deployment.md b/tutorials/cloud_deployments/02-GCP-GKE-deployment.md index 856506f..897f83b 100644 --- a/tutorials/cloud_deployments/02-GCP-GKE-deployment.md +++ b/tutorials/cloud_deployments/02-GCP-GKE-deployment.md @@ -6,13 +6,13 @@ This guide walks you through the script that sets up a vLLM production stack on Before running this setup, ensure you have: -1. GCP CLI installed and configured with credential and region set up. +1. GCP CLI installed and configured with credential and region set up [[Link]](https://cloud.google.com/sdk/docs/install) 2. Kubectl 3. Helm ## TLDR -To run the service +To run the service, go to "deployment_on_cloud/gcp" and run: ```bash sudo bash entry_point.sh YAML_FILE_PATH