Fixed some tutorial problems (#160)

* Updated AWS, bumped release version Signed-off-by: hanchenli <[email protected]> * minor fix to readme in aws Signed-off-by: hanchenli <[email protected]> * minor fix to readme in aws Signed-off-by: hanchenli <[email protected]> * fix format Signed-off-by: hanchenli <[email protected]> * fix folder Signed-off-by: hanchenli <[email protected]> * fix tutorial Signed-off-by: hanchenli <[email protected]> * Fix GKE deployment tutorial Signed-off-by: hanchenli <[email protected]> --------- Signed-off-by: hanchenli <[email protected]>
vllm-project · Feb 20, 2025 · 286a3f4 · 286a3f4
1 parent 5247c69
commit 286a3f4
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 27 deletions.
diff --git a/deployment_on_cloud/aws/clean_up.sh b/deployment_on_cloud/aws/clean_up.sh
@@ -110,32 +110,8 @@ aws eks delete-cluster --name "$CLUSTER_NAME" --region "$REGION"
 echo "Waiting for cluster $CLUSTER_NAME to be deleted..."
 aws eks wait cluster-deleted --name "$CLUSTER_NAME" --region "$REGION"
 
+# TODO
 # Clean up VPC
-# echo "Cleaning up VPC..."
-# VPC_ID=$(aws ec2 describe-vpcs \
-#   --filters "Name=tag:Name,Values=eksctl-${CLUSTER_NAME}-cluster/VPC" \
-#   --query "Vpcs[0].VpcId" \
-#   --output text \
-#   --region "$REGION")
-# if [ -n "$VPC_ID" ]; then
-#   echo "Deleting VPC: $VPC_ID"
-#   aws ec2 delete-vpc --vpc-id "$VPC_ID" --region "$REGION"
-# else
-#   echo "VPC not found, skipping..."
-# fi
-
 # Delete CloudFormation Stackecho "Deleting CloudFormation stacks..."
-# STACKS=( "eksctl-${CLUSTER_NAME}-cluster" "eksctl-${CLUSTER_NAME}-cluster-nodegroup-gpu-nodegroup" )
-# for STACK_NAME in "${STACKS[@]}"; do
-#   STACK_STATUS=$(aws cloudformation describe-stacks --stack-name "$STACK_NAME" --region "$REGION" --query "Stacks[0].StackStatus" --output text 2>/dev/null)
-#   if [ -n "$STACK_STATUS" ]; then
-#     echo "Deleting CloudFormation stack: $STACK_NAME"
-#     aws cloudformation delete-stack --stack-name "$STACK_NAME" --region "$REGION"
-#     echo "Waiting for CloudFormation stack $STACK_NAME to be deleted..."
-#     aws cloudformation wait stack-delete-complete --stack-name "$STACK_NAME" --region "$REGION"
-#   else
-#     echo "CloudFormation stack $STACK_NAME not found, skipping..."
-#   fi
-# done
 
 echo "EKS cluster $CLUSTER_NAME cleanup completed successfully!"
diff --git a/deployment_on_cloud/gke/README.md → deployment_on_cloud/gcp/README.md b/deployment_on_cloud/gke/README.md → deployment_on_cloud/gcp/README.md
diff --git a/deployment_on_cloud/gke/clean_up.sh → deployment_on_cloud/gcp/clean_up.sh b/deployment_on_cloud/gke/clean_up.sh → deployment_on_cloud/gcp/clean_up.sh
diff --git a/deployment_on_cloud/gke/entry_point.sh → deployment_on_cloud/gcp/entry_point.sh b/deployment_on_cloud/gke/entry_point.sh → deployment_on_cloud/gcp/entry_point.sh
diff --git a/...d/gke/production_stack_specification.yaml → ...d/gcp/production_stack_specification.yaml b/...d/gke/production_stack_specification.yaml → ...d/gcp/production_stack_specification.yaml
diff --git a/tutorials/cloud_deployments/02-GCP-GKE-deployment.md b/tutorials/cloud_deployments/02-GCP-GKE-deployment.md
@@ -6,13 +6,13 @@ This guide walks you through the script that sets up a vLLM production stack on
 
 Before running this setup, ensure you have:
 
-1. GCP CLI installed and configured with credential and region set up.
+1. GCP CLI installed and configured with credential and region set up [[Link]](https://cloud.google.com/sdk/docs/install)
 2. Kubectl
 3. Helm
 
 ## TLDR
 
-To run the service
+To run the service, go to "deployment_on_cloud/gcp" and run:
 
 ```bash
 sudo bash entry_point.sh YAML_FILE_PATH