Fix problem in Github workflow

Signed-off-by: ApostaC <[email protected]>
vllm-project · Feb 20, 2025 · 00dec2f · 00dec2f
1 parent b3099dd
commit 00dec2f
Showing 1 changed file with 21 additions and 4 deletions.
diff --git a/.github/workflows/router-docker-release.yml b/.github/workflows/router-docker-release.yml
@@ -24,25 +24,42 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
-      - name: Login to Container Registry
+      # Login to GitHub Container Registry (GHCR)
+      - name: Login to GHCR
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Extract version
+      # Login to Docker Hub
+      - name: Login to Docker Hub
+        uses: docker/login-action@v3
+        with:
+          registry: docker.io
+          username: lmcache
+          password: ${{ secrets.LMCACHE_DOCKER_SECRET }}
+
+      - name: Extract and sanitize version
         id: version
-        run: echo "version=$(python setup.py --version)" >> "$GITHUB_OUTPUT"
+        run: |
+          raw_version=$(python setup.py --version)
+          sanitized_version=$(echo "$raw_version" | sed 's/+/-/g')
+          echo "version=$sanitized_version" >> "$GITHUB_ENV"
+          echo "Sanitized version: $sanitized_version"
+
       - name: Build and push image
         uses: docker/build-push-action@v5
         with:
           context: .
           file: docker/Dockerfile
           push: true
+          # Note: also push the image to Docker Hub as the helm chart uses it by default
           tags: |
             ghcr.io/${{ github.repository }}/router:latest
-            ghcr.io/${{ github.repository }}/router:${{ steps.version.outputs.version }}
+            ghcr.io/${{ github.repository }}/router:${{ env.version }}
             ghcr.io/${{ github.repository }}/router:${{ github.sha }}
+            lmcache/lmcache-router:latest
+            lmcache/lmcache-router:${{ env.version }}
           cache-from: type=registry,ref=ghcr.io/${{ github.repository }}/router:buildcache
           cache-to: type=registry,ref=ghcr.io/${{ github.repository }}/router:buildcache,mode=max