Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Only add night_light if True. #82

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

vlebourl
Copy link
Owner

@vlebourl vlebourl commented Feb 1, 2023

Fixes #81.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 1, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.43%.

Quality metrics Before After Change
Complexity 2.69 ⭐ 2.84 ⭐ 0.15 👎
Method Length 40.72 ⭐ 41.62 ⭐ 0.90 👎
Working memory 5.56 ⭐ 5.59 ⭐ 0.03 👎
Quality 82.30% 81.87% -0.43% 👎
Other metrics Before After Change
Lines 250 245 -5
Changed files Quality Before Quality After Quality Change
custom_components/vesync/diagnostics.py 78.18% ⭐ 75.10% ⭐ -3.08% 👎
custom_components/vesync/light.py 82.76% ⭐ 82.50% ⭐ -0.26% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
custom_components/vesync/light.py VeSyncBaseLight.turn_on 5 ⭐ 128 😞 10 😞 60.44% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added the bug Something isn't working label Feb 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vlebourl vlebourl merged commit 057cbb7 into main Feb 1, 2023
@vlebourl vlebourl deleted the fix/improve-functionality-discovery branch April 18, 2023 07:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dual 200S humidifier nightlight does not seem to be working
1 participant