Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Fix deprecation warning in number entity #44

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

vlebourl
Copy link
Owner

@vlebourl vlebourl commented Aug 3, 2022

Resolves #39

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 3, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.37%.

Quality metrics Before After Change
Complexity 1.33 ⭐ 1.40 ⭐ 0.07 👎
Method Length 21.92 ⭐ 27.46 ⭐ 5.54 👎
Working memory 3.47 ⭐ 3.93 ⭐ 0.46 👎
Quality 93.43% 91.06% -2.37% 👎
Other metrics Before After Change
Lines 182 158 -24
Changed files Quality Before Quality After Quality Change
custom_components/vesync/number.py 93.43% ⭐ 91.06% ⭐ -2.37% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added the bug Something isn't working label Aug 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vlebourl vlebourl merged commit ed79d94 into main Aug 3, 2022
@vlebourl vlebourl deleted the fix/deprecated-method-in-number-entity branch August 3, 2022 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated methods on an instance of NumberEntity,
1 participant