Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Improve constants. #34

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Improve constants. #34

merged 1 commit into from
Jul 30, 2022

Conversation

vlebourl
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 11, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.82%.

Quality metrics Before After Change
Complexity 2.12 ⭐ 2.22 ⭐ 0.10 👎
Method Length 39.38 ⭐ 40.69 ⭐ 1.31 👎
Working memory 5.30 ⭐ 5.33 ⭐ 0.03 👎
Quality 84.74% 83.92% -0.82% 👎
Other metrics Before After Change
Lines 176 193 17
Changed files Quality Before Quality After Quality Change
custom_components/vesync/const.py 87.48% ⭐ 85.80% ⭐ -1.68% 👎
custom_components/vesync/fan.py 84.13% ⭐ 83.36% ⭐ -0.77% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vlebourl vlebourl merged commit a6015cd into main Jul 30, 2022
@vlebourl vlebourl deleted the featurea/reafactor-code branch October 24, 2022 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant