Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Add display switch to fan devices. #32

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Conversation

vlebourl
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 30, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.95%.

Quality metrics Before After Change
Complexity 6.62 ⭐ 6.84 ⭐ 0.22 👎
Method Length 22.20 ⭐ 22.70 ⭐ 0.50 👎
Working memory 4.88 ⭐ 5.02 ⭐ 0.14 👎
Quality 80.82% 79.87% -0.95% 👎
Other metrics Before After Change
Lines 277 280 3
Changed files Quality Before Quality After Quality Change
custom_components/vesync/common.py 67.17% 🙂 66.47% 🙂 -0.70% 👎
custom_components/vesync/switch.py 92.84% ⭐ 91.68% ⭐ -1.16% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
custom_components/vesync/common.py async_process_devices 24 😞 214 ⛔ 8 🙂 41.11% 😞 Refactor to reduce nesting. Try splitting into smaller methods
custom_components/vesync/switch.py _setup_entities 7 ⭐ 92 🙂 10 😞 63.22% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added the bug Something isn't working label Jun 30, 2022
@vlebourl vlebourl linked an issue Jun 30, 2022 that may be closed by this pull request
@vlebourl vlebourl changed the title Improve night_light feature discovery Add display switch to fan devices. Jul 11, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vlebourl vlebourl merged commit 3498625 into main Jul 11, 2022
@vlebourl vlebourl deleted the fix/missing_night_light_entity branch July 11, 2022 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core 300s missing entities
1 participant