Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Add warm mist number entity to compatible devices (600S) #29

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Conversation

vlebourl
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 14, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.90%.

Quality metrics Before After Change
Complexity 0.60 ⭐ 1.02 ⭐ 0.42 👎
Method Length 16.16 ⭐ 16.00 ⭐ -0.16 👍
Working memory 3.55 ⭐ 3.67 ⭐ 0.12 👎
Quality 95.42% 94.52% -0.90% 👎
Other metrics Before After Change
Lines 166 195 29
Changed files Quality Before Quality After Quality Change
custom_components/vesync/number.py 95.42% ⭐ 94.52% ⭐ -0.90% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vlebourl vlebourl changed the title add warm mist number entity Aad warm mist number entity to compatible devices (600S) Jun 14, 2022
@vlebourl vlebourl linked an issue Jun 14, 2022 that may be closed by this pull request
@vlebourl vlebourl added the enhancement New feature or request label Jun 14, 2022
@vlebourl vlebourl changed the title Aad warm mist number entity to compatible devices (600S) Add warm mist number entity to compatible devices (600S) Jun 14, 2022
@vlebourl vlebourl merged commit cdbb0b8 into main Jul 4, 2022
@vlebourl vlebourl deleted the warm_mist branch October 24, 2022 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warm Mist attributes not detected
1 participant