Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Fix modes for LV600S Humidifier #136

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Fix modes for LV600S Humidifier #136

merged 7 commits into from
Apr 18, 2023

Conversation

igor-panteleev
Copy link
Contributor

No description provided.

@vlebourl
Copy link
Owner

hey! thanks for the contribution!
does this fix #125?

@vlebourl
Copy link
Owner

Can you apply pre-commit hooks to reformat the code?
Also can you merge latest main (just pushed it) to fix the hassfest validation?
Cheers

@vlebourl
Copy link
Owner

I don't own the LV600S, do you have a display switch? mine has this:
image
which is mapped to the display switch:
image

I've seen from an other user's LV600S that both Display and Night light switches exist. What do they relate to?

@vlebourl
Copy link
Owner

Just waiting on your answer on #125 and the switches in HA, then happy to merge.

@igor-panteleev
Copy link
Contributor Author

hey! thanks for the contribution! does this fix #125?

Sure, this PR was addressed to fix this issue.

Can you apply pre-commit hooks to reformat the code? Also can you merge latest main (just pushed it) to fix the hassfest validation? Cheers

Just did it. I think a "Contribution" section should be added to the readme file to make this process a bit more obvious.

I've seen from an other user's LV600S that both Display and Night light switches exist. What do they relate to?

For LV600S there is a display switch and it works like it suppose to (turns the display on and off)
For "nightlight" pyvevync list it as a feature for LV600S in VeSyncHumid200300S.features but it seems to be doing nothing. I've been experimenting yesterday with set_night_light_brightness, but changing it seems to have no effect.

@vlebourl
Copy link
Owner

Thanks, I'll merge as is, leaving the nightlight button for now, if this is a fix on the side of pyvesync, I'll maybe open an issue there.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vlebourl vlebourl merged commit 962381d into vlebourl:main Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants