Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Stuck on hyperlink modal #334

Closed
KaKi87 opened this issue Oct 14, 2020 · 16 comments
Closed

[Bug] Stuck on hyperlink modal #334

KaKi87 opened this issue Oct 14, 2020 · 16 comments

Comments

@KaKi87
Copy link

KaKi87 commented Oct 14, 2020

Hello,

When writing an email, once the hyperlink modal is opened, I can't close it, whether I validate or cancel.

Thanks

@vladimiry
Copy link
Owner

Can you verify if this build affected? It's a work-in-progress build assembled as a result of #332 work.

@vladimiry
Copy link
Owner

@KaKi87
Copy link
Author

KaKi87 commented Oct 15, 2020

Hello,
Mega.nz is not working for me, could you try a website that supports direct download ?
Thanks

@vladimiry
Copy link
Owner

website that supports direct download ?

No such option at the moment.

@KaKi87
Copy link
Author

KaKi87 commented Oct 15, 2020

anonfile.com, file.io, etc.

@vladimiry
Copy link
Owner

vladimiry commented Oct 15, 2020

Package type to upload (linux/macos/win)?

@KaKi87
Copy link
Author

KaKi87 commented Oct 15, 2020

AppImage please.

@vladimiry
Copy link
Owner

https://anonfiles.com/Bav1F9f0p4/electron-mail-2020-10-13-v4.9.0-b3aac8a_tar

@KaKi87
Copy link
Author

KaKi87 commented Oct 15, 2020

The bug is fixed in this build, thanks.

@vladimiry
Copy link
Owner

vladimiry commented Oct 15, 2020

Just for you to know. In the build I shared the remote requests to the URL origins other than selected in the "API entry point" dropdown value are blocked by default. So for example you won't be able to load inlined in the email message images. In the released version this is going to be an opt-in feature (disabled by default).

@vladimiry
Copy link
Owner

https://anonfiles.com/Bav1F9f0p4/electron-mail-2020-10-13-v4.9.0-b3aac8a_tar

I don't recommend using this build on daily basis but only testing the original issue case since I have a reason to believe that this version comes with proton web client that has a leading to the privacy-compromising flaw (the issue has been reported). For the same reason, I would not yet use the https://beta.protonmail.com in the browser.

@KaKi87
Copy link
Author

KaKi87 commented Oct 20, 2020

I see, could you please link me that issue ?

@vladimiry
Copy link
Owner

link me that issue ?

The issues of this type are not supposed to be publicly disclosed until they get fixed. I'm going to place update message in #332 when I get new information.

@tianalemesle
Copy link

So, I'm back on v4.8.0, and I can no longer reproduce the bug ? Is it possible that it is still using the same website as in v4.9.0 ?

@vladimiry
Copy link
Owner

vladimiry commented Oct 23, 2020

Is it possible that it is still using the same website as in v4.9.0 ?

Unlikely since the proton's web client packaged in the app is a static asset. But technically it's possible for proton client to load the JS stuff from a remote server and then embed it to the page (I don't think they do that). In not yet released v4.9.0 the Blocking all non "API entry point"-based network requests feature is enabled in order to detect/block unintended/shady network requests, see #312 (comment) for details. By the way, enabling that option suppresses the issue I mentioned in the previous message.

@vladimiry
Copy link
Owner

vladimiry commented Oct 23, 2020

The most recent v4.9.0 build uploaded here. The named before issue gets suppressed by enabling Block non "API entry point"-based network requests option (respective screenshot posted in #312 (comment)) but it also means that you won't be able to load inlined in emails images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants