vi.mock's importOriginal stuck on circular imports

[AriPerkkio]

Describe the bug

When a test imports file that contains circular imports and also mocks some of these files, vi.mock's importOriginal does not resolve. Whats worse is that vite-node silently hangs and doesn't log any timeout errors. Even birpc doesn't timeout here for some reason.

import '../src/module-1';

vi.mock('../src/module-2', async (importOriginal) => {
  console.log('Start importOriginal');
  await importOriginal();
  //    ^^^ Never resolves

  console.log('Done importOriginal');

  return { default: () => {} };
});

$ DEBUG=vite-node:* pnpm run test tests/cyclic-imports.test.ts 

> [email protected] test /<path>/vitest-example-project
> vitest run "tests/cyclic-imports.test.ts"


 RUN  v1.0.0-beta.2 /<path>/vitest-example-project

  vite-node:server:request /@vite/env +0ms
2023-10-25T18:22:43.172Z vite-node:client:execute /@vite/env
2023-10-25T18:22:43.174Z vite-node:client:native /<path>/vitest/packages/vitest/dist/spy.js
2023-10-25T18:22:43.200Z vite-node:client:native /<path>/vitest/packages/vitest/dist/runners.js
  vite-node:server:request /<path>/vitest-example-project/tests/cyclic-imports.test.ts +42ms
2023-10-25T18:22:43.210Z vite-node:client:execute /<path>/vitest-example-project/tests/cyclic-imports.test.ts
2023-10-25T18:22:43.211Z vite-node:client:native /<path>/vitest/packages/vitest/dist/index.js
  vite-node:server:request /src/module-1.ts +11ms
2023-10-25T18:22:43.215Z vite-node:client:execute /<path>/vitest-example-project/src/module-1.ts
  vite-node:server:request /<path>/vitest-example-project/src/module-2.ts +28ms
stdout | tests/cyclic-imports.test.ts:3:11
Start importOriginal

2023-10-25T18:22:43.244Z vite-node:client:execute /<path>/vitest-example-project/src/module-2.ts
  vite-node:server:request /src/module-3.ts +3ms
2023-10-25T18:22:43.246Z vite-node:client:execute /<path>/vitest-example-project/src/module-3.ts
  vite-node:server:request /src/module-4.ts +3ms
2023-10-25T18:22:43.248Z vite-node:client:execute /<path>/vitest-example-project/src/module-4.ts

# Stuck here, CTRL+C terminates process correctly

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-8gzjhq?file=test%2Fcyclic-import.test.mjs

System Info

Stackblitz

- Vitest v1 beta and 0.3x.x releases

Used Package Manager

pnpm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitest-dev-vitest-8gzjhq (Open reproduction)

[transfer1992]

Very frustrating, especially because it is completely silent. Spent few hours on this.

[mcclayton]

This issue appears to be related to:
#4026

I ultimately fixed this for myself by addressing the circular dependencies (using the eslint rule: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-cycle.md#when-not-to-use-it)

However, it was incredibly difficult to determine that it was ultimately the circular dependencies since vitest just hung without any error output or timeout. Hope these issues can get visibility for others stuck with this.

[AriPerkkio]

I ran into this issue again - this time caused by circular dependency coming from a barrel file. By using the VITE_NODE_DEBUG_RUNNER=true it's possible to see the modules that are stuck loading. From those logs I could figure out the root cause.

vitest/packages/vite-node/README.md

Lines 152 to 158 in 039814b

	### Debug Execution
	If the process gets stuck, it might be because there are unresolvable circular dependencies. You can set `VITE_NODE_DEBUG_RUNNER=true` for vite-node to warn about this.
	```bash
	VITE_NODE_DEBUG_RUNNER=true vite-node example.ts
	```

[sheremet-va]

I found the culprit, PR incoming.

[dlvhdr]

How can I test this fix?
I have a yarn v1 monorepo and can't figure out how to test this change.
I tried using the "vitest": "file:/Users/dlvhdr/code/misc/vitest/packages/vitest" syntax, as well as running vitest from the build artifacts.
For the first - yarn doesn't know what I mean
For the latter - I get a weird error:0909006C:PEM routines:get_name:no start line error.

Alternatively, can a new release be made with the fix?

[dlvhdr]

Ok I managed to make it work and this does fix the issue. I just had to remove the packageManager entry from the package.json.