From 4e60333dc7235704f96314c34ca510e3901fe61f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ari=20Perkki=C3=B6?= Date: Wed, 11 Dec 2024 16:31:03 +0200 Subject: [PATCH] fix(benchmark): disable type testing while benchmarking (#7068) --- packages/vitest/src/node/config/resolveConfig.ts | 1 + test/benchmark/fixtures/basic/should-not-run.test-d.ts | 7 +++++++ test/benchmark/test/basic.test.ts | 3 +++ tsconfig.check.json | 1 + 4 files changed, 12 insertions(+) create mode 100644 test/benchmark/fixtures/basic/should-not-run.test-d.ts diff --git a/packages/vitest/src/node/config/resolveConfig.ts b/packages/vitest/src/node/config/resolveConfig.ts index 78f19e22094a..66c0ce6ef62c 100644 --- a/packages/vitest/src/node/config/resolveConfig.ts +++ b/packages/vitest/src/node/config/resolveConfig.ts @@ -557,6 +557,7 @@ export function resolveConfig( } // override test config resolved.coverage.enabled = false + resolved.typecheck.enabled = false resolved.include = resolved.benchmark.include resolved.exclude = resolved.benchmark.exclude resolved.includeSource = resolved.benchmark.includeSource diff --git a/test/benchmark/fixtures/basic/should-not-run.test-d.ts b/test/benchmark/fixtures/basic/should-not-run.test-d.ts new file mode 100644 index 000000000000..eb35b7540de5 --- /dev/null +++ b/test/benchmark/fixtures/basic/should-not-run.test-d.ts @@ -0,0 +1,7 @@ +import { describe, expectTypeOf, test } from 'vitest' + +describe('test', () => { + test('some-test', () => { + expectTypeOf({ a: 1 }).toEqualTypeOf({ a: "should not match" }) + }) +}) diff --git a/test/benchmark/test/basic.test.ts b/test/benchmark/test/basic.test.ts index b20ff4d3e75d..b0cb1e0f72ec 100644 --- a/test/benchmark/test/basic.test.ts +++ b/test/benchmark/test/basic.test.ts @@ -13,6 +13,9 @@ it('basic', { timeout: 60_000 }, async () => { root, allowOnly: true, outputJson: 'bench.json', + + // Verify that type testing cannot be used with benchmark + typecheck: { enabled: true }, }, [], 'benchmark') expect(result.exitCode).toBe(0) diff --git a/tsconfig.check.json b/tsconfig.check.json index 2a9e09dc9daf..fe3fa7d051bb 100644 --- a/tsconfig.check.json +++ b/tsconfig.check.json @@ -14,6 +14,7 @@ "./packages/ui/client/**", "./examples/**/*.*", "./bench/**", + "./test/benchmark/fixtures/**", "./test/typescript/**", "./test/browser/**", "**/coverage/fixtures/**",