Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure no AST types are bare slices #17674

Merged
merged 24 commits into from
Feb 6, 2025

remove generating logs for slow slice types

874f74a
Select commit
Loading
Failed to load commit list.
Refresh
Merged

Make sure no AST types are bare slices #17674

remove generating logs for slow slice types
874f74a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 1s

67.76% (+0.01%) compared to 78c7470

View this Pull Request on Codecov

67.76% (+0.01%) compared to 78c7470

Details

Codecov Report

Attention: Patch coverage is 68.33333% with 171 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (78c7470) to head (874f74a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
go/tools/asthelpergen/integration/ast_rewrite.go 25.33% 56 Missing ⚠️
go/vt/sqlparser/ast.go 16.27% 36 Missing ⚠️
go/tools/astfmtgen/main.go 0.00% 20 Missing ⚠️
go/vt/sqlparser/tracked_buffer.go 56.09% 18 Missing ⚠️
go/vt/sqlparser/ast_funcs.go 76.92% 9 Missing ⚠️
go/vt/sqlparser/ast_format.go 79.16% 5 Missing ⚠️
go/vt/vtgate/planbuilder/operators/SQL_builder.go 63.63% 4 Missing ⚠️
go/vt/sqlparser/random_expr.go 40.00% 3 Missing ⚠️
go/vt/vtgate/planbuilder/operators/projection.go 50.00% 3 Missing ⚠️
go/vt/vtgate/semantics/semantic_table.go 70.00% 3 Missing ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17674      +/-   ##
==========================================
+ Coverage   67.74%   67.76%   +0.01%     
==========================================
  Files        1587     1587              
  Lines      255780   255906     +126     
==========================================
+ Hits       173280   173412     +132     
+ Misses      82500    82494       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov