Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using JSX? #871

Closed
ThisIsOstad opened this issue Aug 22, 2019 · 2 comments
Closed

Using JSX? #871

ThisIsOstad opened this issue Aug 22, 2019 · 2 comments

Comments

@ThisIsOstad
Copy link
Contributor

Hi. Thanks for all the great work.

I'm wondering if there is any reason (or blocking issue) not using JSX in this project?
I think it will be much simpler to understand components sources and contribute when using JSX.

If it's OK I can try it with a pull request.

@ibgreen
Copy link
Contributor

ibgreen commented Aug 22, 2019

Do not have an opinion but I can provide some background:

We used to write all our projects in pure JavaScript (ES6/ES2018) and run code in latest Chrome and test in Node.js without transpilation (better debug experience, no source maps needed). Using JSX would mean having to introduce babel or similar, we have very few React components and benefit of JSX was small)

However, I believe this project has since introduced flow, which while not hard to strip away does diverge from the original "pure JS" setup. Also more React components have been added, increasing the value of JSX.

@ThisIsOstad
Copy link
Contributor Author

@ibgreen Thanks for the information.

As babel is being used in this project now, I agree with you that using/migrating to JSX is a valuable option at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants