Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve map ColorScheme and RenderingType types #675

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Improve map ColorScheme and RenderingType types #675

merged 1 commit into from
Jan 28, 2025

Conversation

TiagoPortfolio
Copy link
Contributor

Changed the ColorScheme and RenderingType types to use const to avoid being inferred as a string instead of the literal value.

@usefulthink
Copy link
Collaborator

Thanks, that seems like a good idea!
I don't think this should be a problem for any existing users, correct?

@usefulthink usefulthink merged commit 785927a into visgl:main Jan 28, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Merged
@TiagoPortfolio
Copy link
Contributor Author

Thanks, that seems like a good idea! I don't think this should be a problem for any existing users, correct?

Correct.
If anything, existing users will be warned if they are using an invalid color scheme or rendering type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiagoPortfolio @usefulthink