Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use deep compare effect to prevent infowindow close #642

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: use deep compare effect to prevent infowindow close #642

merged 1 commit into from
Jan 2, 2025

Conversation

mrMetalWood
Copy link
Collaborator

The infowindowOptions was a new object on every render thus resulting in the infowindow getting closed when the map was panned or zoomed

addresses #628

@usefulthink usefulthink merged commit bfa85c1 into visgl:main Jan 2, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Merged
@kylegoines
Copy link

kylegoines commented Jan 6, 2025 •
edited
Loading

hello! i was hoping to know if theres going to be a published release for this fix, its vital to my project and the release schedule :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usefulthink usefulthink Awaiting requested review from usefulthink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrMetalWood @kylegoines @usefulthink