Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lampo panics on invalid bolt12 #318

Closed
Harshit933 opened this issue Dec 7, 2024 · 2 comments
Closed

Lampo panics on invalid bolt12 #318

Harshit933 opened this issue Dec 7, 2024 · 2 comments
Assignees
Labels
🦀 - rust Rust related things bug Something isn't working P-hight Hiight Priotity issue
Milestone

Comments

@Harshit933
Copy link
Collaborator

Lampo panics on providing invalid bolt12.

2024-12-07T09:01:22.564Z INFO lampod::jsonrpc::offchain call for `invoice` with request `Object {"invoice_str": String("lno1qgsyxjtl6luzd9t3pr62xr7eemp6awnejusgf6gw45q75vcfqqqqqqqsespexwyy4tcadvgg89l9aljus6709kx235hhqrk6n8dey98uyuftzdqzrtkahuum7m56dxlnx8r6tffy54004l7kvs7pylmxx7xs4n54986qyqeeuhhunayntt50snmdkq4t7fzsgghpl69v9csgparek8kv7dlp5uqr8ymp5s4z9upmwr2s8xu020d45t5phqc8nljrq8gzsjmurzevawjz6j6rc95xwfvnhgfx6v4c3jha7jwynecrz3y092nn25ek4yl7xp9yu9ry9zqagt0ktn4wwvqg52v9ss9ls22sqyqqestzp2l6decpn87pq96udsv")}`. [lampod/src/jsonrpc/offchain.rs:63]
thread '<unnamed>' panicked at lampod/src/jsonrpc/offchain.rs:113:9:
internal error: entered unreachable code
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

We should probably return an error stating "invalid bolt12"

@Harshit933 Harshit933 added P-waiting Waiting for the issue triage 🦀 - rust Rust related things labels Dec 7, 2024
@vincenzopalazzo
Copy link
Owner

you find another thing to work on! thanks for reporting it

@vincenzopalazzo vincenzopalazzo added bug Something isn't working P-hight Hiight Priotity issue and removed P-waiting Waiting for the issue triage labels Dec 7, 2024
@vincenzopalazzo vincenzopalazzo added this to the v24.08 milestone Dec 7, 2024
@vincenzopalazzo vincenzopalazzo moved this to Todo in v24.12 Dec 7, 2024
@vincenzopalazzo
Copy link
Owner

Fixed in #324

@github-project-automation github-project-automation bot moved this from Todo to Done in v24.12 Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦀 - rust Rust related things bug Something isn't working P-hight Hiight Priotity issue
Projects
Status: Done
Development

No branches or pull requests

2 participants