Fixes related to address inside conf.
#234
Conversation
This commit removes the `127.0.0.1` address as the default address for the node to listen for incoming connections. Also, we do not stop the node, we just give the warning that the node is not reachable.
| @@ -203,6 +204,7 @@ impl LampoPeerManager { | |||
| } | |||
| result | |||
| }); | |||
| result.join().unwrap()?; | |||
There was a problem hiding this comment.
Why this change? you are blocking lampo so from this join the code will never return, Have you tested the code?
There was a problem hiding this comment.
We simply return from the thread when we are not able to bind the address.
https://github.com/vincenzopalazzo/lampo.rs/blob/a973f1548e0f076cf7016783f6eb021d1407e928/lampod/src/ln/peer_manager.rs#L147C67-L147C74
Then we just join the child thread with the main thread and see if there are any errors that we get from there.
I have tested this.
There was a problem hiding this comment.
are you sure that the join will not block the execution of the lampo::listen? can you add an extra log::info and see if you see it?
There was a problem hiding this comment.
I still need to see this, Will do in this week!
There was a problem hiding this comment.
Take your time, this will be in the august release
When the address specified inside the `conf` is invalid or could not be binded we should ideally stop the node. This case was not handled earlier.
Harshit933
force-pushed
the
network/address
branch
from
0f57638 to
2e1ad4f
Compare
|
Closing because inactive |
There are two things that are addressed here :
announce-addrinsideconfis not present.announce-addrmentioned inside theconfis wrong or could not be binded.Fixes Remove the default address as
127.0.0.1#231