Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpc: return a warning everytime a json response get handled #230

Closed
vincenzopalazzo opened this issue May 25, 2024 · 5 comments
Closed
Assignees
Labels
🦀 - rust Rust related things bug Something isn't working P-low Low priority issue

Comments

@vincenzopalazzo
Copy link
Owner

vincenzopalazzo commented May 25, 2024

          This gives me the warning everytime I run `lampo-cli --network regtest getinfo`. 
2024-05-24T16:13:35.386Z WARN jsonrpc event invalid: Event { key: Connect, source: Source { fd: 15, events: 519, revents: 32 } }. [lampo-jsonrpc/src/lib.rs:281]

This is the basic flow of events whenever I am querying the node.

  1. RPCEvent::Accept
  2. RPCEvent::Connect && event.is_readable()
  3. RPCEvent::Connect and the event.is_invalid() -> This throws the warning.

Originally posted by @Harshit933 in #219 (comment)

@vincenzopalazzo vincenzopalazzo added bug Something isn't working 🦀 - rust Rust related things labels May 25, 2024
@vincenzopalazzo vincenzopalazzo added this to the v24.06 milestone May 25, 2024
@vincenzopalazzo vincenzopalazzo moved this to Todo in v24.06 May 25, 2024
@vincenzopalazzo vincenzopalazzo removed this from the v24.06 milestone May 25, 2024
@Harshit933
Copy link
Collaborator

I will take this.

@vincenzopalazzo
Copy link
Owner Author

I do not think this is a task for you @Harshit933, this is a problem on how we use pool at the kernel level

Or your already know how to fix it?

@Harshit933
Copy link
Collaborator

I do not know. But if you are working on this you would do far better than me :)

@vincenzopalazzo
Copy link
Owner Author

I think we should not waste time in bug that we do not know how to solve. You have already a lot of work on your plate

@vincenzopalazzo vincenzopalazzo added the P-low Low priority issue label May 30, 2024
@vincenzopalazzo vincenzopalazzo self-assigned this Jun 3, 2024
@vincenzopalazzo vincenzopalazzo moved this from Todo to In Progress in v24.06 Jun 3, 2024
@vincenzopalazzo
Copy link
Owner Author

Fixed in #242

@github-project-automation github-project-automation bot moved this from In Progress to Done in v24.06 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦀 - rust Rust related things bug Something isn't working P-low Low priority issue
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants