Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to remove unmatched issueHandlers #3262

Closed
williamdes opened this issue Apr 28, 2020 · 3 comments
Closed

Suggest to remove unmatched issueHandlers #3262

williamdes opened this issue Apr 28, 2020 · 3 comments

Comments

@williamdes
Copy link

williamdes commented Apr 28, 2020

<LessSpecificReturnType errorLevel="info" /> I had added some ignore errors and they got unused.

I would suggest that like phpstan has you add something to report the unmatched issueHandlers
Like I did on phpmyadmin/phpmyadmin@29bbf03

And 2nd possible feature: suggest to the user to make the rule file specific if it hits only x files
So the user can stop propagating error y on more files than x without knowing it

Thank you for the tool, I am adding it to phpMyAdmin dev tools !
phpmyadmin/phpmyadmin#16100

@williamdes
Copy link
Author

Hi @muglug
Do you think this feature would be usefull ?

@robchett
Copy link
Contributor

robchett commented Nov 3, 2023

Unused issue handler PR added in #10341.

It won't suggest narrowing the list of files/directories but I think it could fairly easily be expanded to do so by breaking up the issue handler into multiple when parsing them from the XM.

@weirdan
Copy link
Collaborator

weirdan commented Jan 27, 2024

Fixed, as per above.

@weirdan weirdan closed this as completed Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants