Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7.x obsolete warnings #42

Open
johnphamvan opened this issue May 13, 2020 · 1 comment
Open

Ruby 2.7.x obsolete warnings #42

johnphamvan opened this issue May 13, 2020 · 1 comment

Comments

@johnphamvan
Copy link

Ruby 2.7.x triggers obsolete warnings for URI.escape. Could we consider using the well-maintained Addressable gem (https://github.com/sporkmonger/addressable) or using a different approach like CGI::escape or ERB::Util.url_encode?

I can create a pull request if that helps.

/usr/local/Cellar/rbenv/1.1.2/versions/2.7.1/lib/ruby/gems/2.7.0/gems/kimurai-1.4.0/lib/kimurai/base_helper.rb:7: warning: URI.escape is obsolete

Thanks.

@rubyFeedback
Copy link

Yeah that was a bit annoying to deal with, but I slowly changed this in my own projects too. Most use
I actually had was via .open() aka URI.open() now.

Warnings can cause quite some extra work to projects ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants