Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set poster image #955

Closed
onetwo12 opened this issue Jan 21, 2014 · 3 comments
Closed

Set poster image #955

onetwo12 opened this issue Jan 21, 2014 · 3 comments

Comments

@onetwo12
Copy link

I am trying to set poster image after the player is initialized but with no success. I am
using this version of the player https://github.com/videojs/video.js-component (since I don't know how to make build from the source files).

I saw here #525 that changes are made with the new 'posterchange' event but the commit is done after the last version on video.js-component.

Is this change #525 going to enable changing poster image after initialization?

@heff
Copy link
Member

heff commented Jan 21, 2014

That update hasn't been released in a version yet but should be soon.

If you follow the steps in the contributing doc, you can build a version that has the update.

@heff heff closed this as completed Jan 21, 2014
@smohadjer
Copy link

IMO you shouldn't close a bug report as long as the bug still exists in latest released version of your code.

Isn't the whole point of all these automated tests and build processes to release software faster? As I see it's more than six months since the fix was committed for poster change.

@heff
Copy link
Member

heff commented Feb 20, 2014

I disagree on the first point, but agree on the second. I've been doing a lot of work to speed up the release process over the last few weeks so that should improve. The biggest challenge is still automated testing across browsers and devices. There's still a lot of manual testing that's required, and will be until device emulators actually perform like real devices when it comes to video.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants