Update notice about tracking pixel in readme #5361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it's better to leave it in but stress that it's only in older versions? Otherwise, yes, Video.js 7 doesn't include the tracking pixel. |
|
Video.js v6.x is still supported, so the information needs to stay, but it could be re-written to change the emphasis. |
|
This looks like a good additional description: https://blog.videojs.com/video-js-7-is-here/#Google-Analytics |
thijstriemstra
changed the title
|
@thijstriemstra want to update the README with the snippet from the blogpost? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
gkatsev
added a commit
that referenced
this pull request
Oct 10, 2018
gkatsev
added a commit
that referenced
this pull request
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afaik the tracking pixel has been removed so this message can be removed from the readme.
Also bumped version nrs and added vjs-default-skin class to example.