fix: Allow evented objects, such as components and plugins, to listen to the window object in addition to DOM objects. #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the window object in addition to DOM objects.
misteroneill
force-pushed
the
fix/window-events
branch
from
a025c54 to
0fc7a16
Compare
gkatsev
reviewed
Jun 15, 2018
src/js/mixins/evented.js
Outdated
| */ | ||
| const supportsNativeEvents = (object) => | ||
| (typeof window.EventTarget === 'function' && object instanceof window.EventTarget) || | ||
| typeof object.addEventListener === 'function'; |
There was a problem hiding this comment.
what about only just doing the addEventListener check?
brandonocasey
approved these changes
Jun 19, 2018
|
Confirmed that this works via https://deploy-preview-5255--videojs-docs.netlify.com/test-example/ and player.on(window, 'click', (e) => console.log(e.type)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's an issue for this (I looked), but the bug is that objects using the new-ish
eventedmixin cannot listen to thewindowobject, preventing things like:This fixes that so anything that's a native
EventTargetworks.Specific Changes proposed
Allow any native
EventTargetto be a listening target.Requirements Checklist
Docs/guides updatedExample created (starter template on JSBin)