fix: menu sizing when using longer caption labels #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually works, though, it's not quite aligned properly with the text anymore for a short label, adding |
|
Haven't noticed this until you pointed out. Aligning the icon with negative |
|
@OwenEdwards hey can you take a look at this? Especially wrt your PR #4599. |
|
This change, rolled into #4599, fixes that PR completely! So this LGTM. |
OwenEdwards
added a commit
to OwenEdwards/video.js
that referenced
this pull request
Jun 7, 2018
misteroneill
approved these changes
Jun 7, 2018
gkatsev
pushed a commit
that referenced
this pull request
Jun 11, 2018
Currently, if longer captions labels are used the SubsCaps menu gets all messed up in IE11/Edge. This occurs due to the menu size is not adjusted correctly not taking into consideration the CC icon. This, as a result, causes the captions items not to fit in the menu and because they end up too wide and the menu has overflow: auto style, the horizontal scrollbars show up and cause the menu not to render correctly. Therefore, don't position the caption label absolutely. Fix #4758.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed solution for #4758
Currently, if longer captions labels are used the SubsCaps menu gets all messed up in IE11/Edge. This occurs due to the menu size is not adjusted correctly not taking into consideration the CC icon. This, as a result, causes the captions items not to fit in the menu and because they end up too wide and the menu has
overflow: autostyle, the horizontal scrollbars show up and cause the menu not to render correctly.Specific Changes proposed
Do not position the CC icon absolutely.
Requirements Checklist