Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how to Land a PR using the GitHub UI #5201

Merged
merged 1 commit into from
May 23, 2018
Merged

Clarify how to Land a PR using the GitHub UI #5201

merged 1 commit into from
May 23, 2018

Conversation

OwenEdwards
Copy link
Member

Clarify how to enter the header and body text when Landing a PR using the GitHub UI.

@OwenEdwards
Clarify how to Land a PR using the GitHub UI
a7cb693 
Clarify how to enter the header and body text when Landing a PR using the GitHub UI.
@OwenEdwards OwenEdwards requested a review from gkatsev May 23, 2018 19:54
@OwenEdwards OwenEdwards added the needs: LGTM Needs one or more additional approvals label May 23, 2018
gkatsev
gkatsev approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, much better.

We could also include a screenshot at some point.

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels May 23, 2018
@gkatsev gkatsev merged commit 94e54fc into master May 23, 2018
@gkatsev gkatsev deleted the OwenEdwards-collaborator-guide-tweak branch May 23, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OwenEdwards @gkatsev