-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update rollup and uglify and the build process #5096
Conversation
When using |
So I guess its faster to minify outside of rollup here? |
yup, because it doesn't need to do a lot of work yet another time plus we're sharing the name cache between builds. But the total build time from old stuff to new stuff is maybe half. |
is the output any smaller/bigger? |
It's pretty much the same size |
This has benefit of using a default config for rollup and makes the config a lot more maintainable without weird custom code. |
This is a WIP PR that upgrades rollup and uglify to latest versions. It also rewrites the rollup config to take advantage of the newest features of rollup. Minification is also split up into a separate process, mostly to speed up the build. The total build type can go down from about 2.5 minutes to around 1 minute for all the generated javascript files.
TODO:
npm run build
npm start
build/rollup.js
file