fix: Fix an issue where disabling the progress control would throw an error. #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Mar 1, 2018
| @@ -247,7 +247,9 @@ class SeekBar extends Slider { | |||
| super.handleMouseUp(event); | |||
|
|
|||
| // Stop event propagation to prevent double fire in progress-control.js | |||
| event.stopPropagation(); | |||
| if (event) { | |||
There was a problem hiding this comment.
why do we end up calling this function without an event?
There was a problem hiding this comment.
There was a problem hiding this comment.
And then:
There was a problem hiding this comment.
ah, I was trying to find where this could happen but only found cases that pass an event object through, but I guess there's a possibility of it not existing.
gkatsev
approved these changes
Mar 1, 2018
| @@ -247,7 +247,9 @@ class SeekBar extends Slider { | |||
| super.handleMouseUp(event); | |||
|
|
|||
| // Stop event propagation to prevent double fire in progress-control.js | |||
| event.stopPropagation(); | |||
| if (event) { | |||
There was a problem hiding this comment.
ah, I was trying to find where this could happen but only found cases that pass an event object through, but I guess there's a possibility of it not existing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a small issue when the progress control is disabled, this code throws an error because it gets called without an event object.