-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: let the tech preload auto on its own #4861
Conversation
This currently fires two sourcesets: video.js/test/unit/sourceset.test.js Lines 166 to 178 in d7f45ba
|
4d06efc
to
72fa675
Compare
Since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still a bit concerned about potential side-effects of this, though, since sourceset is feature-flagged currently, we can limit its affect.
@@ -2471,11 +2471,7 @@ class Player extends Component { | |||
this.techCall_('src', source.src); | |||
} | |||
|
|||
if (this.options_.preload === 'auto') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about skipping this is enableSourceset
is set?
src/js/player.js
Outdated
} | ||
|
||
// Set the source synchronously if possible (#2326) | ||
// Set the source synchronously if possible (#2326) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this indent is interesting. I think it was dedented so that it lines up with the this.ready call, not sure if it's necessary or not. Maybe we want to make a new line for the arg and have the comment directly above the arg?
I think we may be better off testing if this causes breakage with some QA, but if we just want to do it later we could put it behind the |
QA-LGTM |
This was found due to the work done in #4660. Basically we reload the video element twice on every source with preload set to auto. This can potentially cause the same data to be downloaded twice.
Description
This was found due to the work done in #4660. Basically we reload the video element twice on every source with preload set to auto. This can potentially cause the same data to be downloaded twice.
Specific Changes proposed
Requirements Checklist