modified existing conditional so that time tooltips will not be added… #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to a player on mobile devices
gkatsev
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to a player on mobile devices
Description
Currently, the behavior of time tooltips is inconsistent across iOS and Android devices, so the decision was made by @gkatsev to hide tooltips on all mobile devices (for at least the time being).
Specific Changes proposed
Modify existing conditionals in
seek-bar.jsandplay-progress-bar.jsso that theTimeTooltipandMouseTimeDisplaycomponents will not be added to a player when it is initialized in iOS or Android.Requirements Checklist