-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebVTT issues with Firefox 50 #3819
Comments
I have a built fork of video.js master here: https://github.com/learningequality/video.js/tree/firefox50-dist which is using a vtt.js build from my own git repo. |
I'm trying it locally and I'm not seeing any issues. Do you happen to have a reduced test case? Does it happen with the current releases or with a version of vtt.js from master? |
No :( I can't reproduce it with the CDN version in FF 50. Maybe it is - as you say - an error that has already been patched in your vtt.js fork.
It's the current vtt.js release 0.12.1, the issue is already identified and a PR open in Mozilla's repo as stated. So just to summarize: This issue does not affect the video.js CDN built, but would it still affect self-hosted and other types of source builds that include vtt.js, and is this even supported? Is there a way to be running self-hosted stuff with the video.js fork of vtt.js? Or is there a way for these changes to make it back upstream or video.js to switch back to Mozilla's releases? Please correct me if I was jumping to conclusions :) |
Description
I've found that WebVTT with vtt.js is broken in Firefox 50. This is elaborated here: mozilla/vtt.js#354
The PR that fixes it hasn't been merged and released yet:The PR with the fix has been merged and is waiting to be released:
mozilla/vtt.js#359
This issue can be fixed once 0.13.0 of vtt.js is released, which it seems they want to do once the PR is merged.
Steps to reproduce
Please see the issues in vtt.js
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
Same errors in 5.8.0, 5.12.6, and latest 5.13.2 release
browsers
Firefox 50
OSes
All AFAIK
The text was updated successfully, but these errors were encountered: